param p can not be empty